git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] json_writer: new routines to create data in JSON format

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Jun 4, 2018, 09:41 UTC
Message-ID
<27b02292-9434-edfb-fa43-549973bf7b93@jeffhostetler.com>
In-Reply-To
<20180602051344.GA28311@sigill.intra.peff.net>
On 6/2/2018 1:13 AM, Jeff King wrote:
Show 13 quoted lines
> On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote:
> 
>> On Mon, Mar 26, 2018 at 4:31 PM,  <git@jeffhostetler.com> wrote:
>>> +static inline void assert_in_array(const struct json_writer *jw)
>>> +{
>>> +       if (!jw->open_stack.len)
>>> +               die("json-writer: array: missing jw_array_begin()");
>>
>> When you reroll, please consider marking all these string for
>> translation with _(), unless these are for machine consumption.
> 
> Actually, these are all basically asserts, I think. So ideally they'd be
> BUG()s and not translated.

Yes, these are basically asserts. I'll convert them to BUG's and send up another version this week.

Thanks Jeff

Previous: Jeff King
Message 14 of 14 in “routines to generate JSON data”
  1. routines to generate JSON datagit@jeffhostetler.com, Mar 26, 2018
  2. json_writer: new routines to create data in JSON formatgit@jeffhostetler.com, Mar 26, 2018
  3. Ramsay JonesMar 27, 2018
  4. Jeff HostetlerMar 27, 2018
  5. Ramsay JonesMar 27, 2018
  6. Jeff HostetlerMar 27, 2018
  7. Wink SavilleMar 27, 2018
  8. Randall S. BeckerMar 27, 2018
  9. Junio C HamanoMar 28, 2018
  10. Ramsay JonesMar 27, 2018
  11. Junio C HamanoMar 28, 2018
  12. Duy NguyenJun 2, 2018
  13. Jeff KingJun 2, 2018
  14. Jeff HostetlerJun 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.