Re: [PATCH v4] json_writer: new routines to create data in JSON format
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Jun 4, 2018, 09:41 UTC
- Message-ID
- <27b02292-9434-edfb-fa43-549973bf7b93@jeffhostetler.com>
- In-Reply-To
- <20180602051344.GA28311@sigill.intra.peff.net>
On 6/2/2018 1:13 AM, Jeff King wrote:
Show 13 quoted lines
> On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote:
>
>> On Mon, Mar 26, 2018 at 4:31 PM, <git@jeffhostetler.com> wrote:
>>> +static inline void assert_in_array(const struct json_writer *jw)
>>> +{
>>> + if (!jw->open_stack.len)
>>> + die("json-writer: array: missing jw_array_begin()");
>>
>> When you reroll, please consider marking all these string for
>> translation with _(), unless these are for machine consumption.
>
> Actually, these are all basically asserts, I think. So ideally they'd be
> BUG()s and not translated.Yes, these are basically asserts. I'll convert them to BUG's and send up another version this week.
Thanks Jeff