Re: [PATCH v4] json_writer: new routines to create data in JSON format

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Mar 27, 2018, 15:45 UTC
Message-ID: <ad15ccab-088d-b827-a9fa-c83d397c3479@ramsayjones.plus.com>
In-Reply-To: <ce076d5e-f30f-006e-a25e-ff1a900562bf@ramsayjones.plus.com>

On 27/03/18 04:18, Ramsay Jones wrote:

Show 9 quoted lines

> On 26/03/18 15:31, git@jeffhostetler.com wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
> [snip]
> 
> Thanks, this version fixes all issues I had (with the compilation
> and sparse warnings).
> 
> [Was using UINT64_C(0xffffffffffffffff) a problem on windows?]

BTW, I forgot to mention that you had some whitespace problems with this patch, viz:

  $ git log --oneline -1 --check master-json
  ab643d838 (master-json) json_writer: new routines to create data in JSON format
  t/helper/test-json-writer.c:280: trailing whitespace.
  + */ 
  t/t0019-json-writer.sh:179: indent with spaces.
  +        "g": 0,
  t/t0019-json-writer.sh:180: indent with spaces.
  +        "h": 1
  $

ATB, Ramsay Jones