Re:Re: [PATCH v3 1/4] bundle-uri: verify oid before writing refs

From: Xing Xin <bupt_xingxin@163.com>
Date: May 30, 2024, 08:32 UTC
Message-ID: <c990a2f.8915.18fc8a0cc48.Coremail.bupt_xingxin@163.com>
In-Reply-To: <ZlXGI4lkaXcD7_8C@tanuki>

At 2024-05-28 19:55:15, "Patrick Steinhardt" <ps@pks.im> wrote: [snip]

>>    which means that the `raw_object_store->packed_git` data gets filled
>>    in and ``packed_git_initialized` is set. This also means consecutive
>
>s/``/`/

Copy that.

[snip]

>
>> And a set of negotiation related tests for bundle-uri are added.
>
>s/And/Add/

The "And" is correct here, though I changed the commit message in the new version. :)

[snip]

>As far as I can see there is no test that verifies the case where the
>bundle contains refs, but misses the objects to satisfy the refs. Can we
>craft such a bundle and exercise this new failure mode?

A new test is added in [PATCH v4 1/4], which shows it correctly refuses to target a bundle reference to a non-existent object.

Xing Xin