Re: [PATCH v3 2/4] unbundle: introduce unbundle_fsck_flags for fsckobjects handling
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 28, 2024, 12:03 UTC
- Message-ID
- <ZlXIDXfc_1lGb51J@tanuki>
- In-Reply-To
- <057c697970ff49301cd9dc6adef099f53d440c3c.1716824518.git.gitgitgadget@gmail.com>
On Mon, May 27, 2024 at 03:41:55PM +0000, Xing Xin via GitGitGadget wrote: [snip]
Show 16 quoted lines
> diff --git a/bundle.h b/bundle.h
> index 021adbdcbb3..cfa9daddda6 100644
> --- a/bundle.h
> +++ b/bundle.h
> @@ -30,6 +30,11 @@ int create_bundle(struct repository *r, const char *path,
> int argc, const char **argv, struct strvec *pack_options,
> int version);
>
> +enum unbundle_fsck_flags {
> + UNBUNDLE_FSCK_NEVER = 0,
> + UNBUNDLE_FSCK_ALWAYS,
> +};
> +
> enum verify_bundle_flags {
> VERIFY_BUNDLE_VERBOSE = (1 << 0),
> VERIFY_BUNDLE_QUIET = (1 << 1),Wouldn't this have been a natural fit for the new flag, e.g. via something like `VERIFY_BUNDLE_FSCK`?
Patrick