git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] pull: handle --log=<n>

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 13, 2015, 12:23 UTC
Message-ID
<c8dc145fcc56d38e04fc0e07ceb34999@www.dscho.org>
In-Reply-To
<vpqlhgszujc.fsf@anie.imag.fr>
Hi Matthieu,
On 2015-05-13 11:38, Matthieu Moy wrote:
Show 10 quoted lines
> Paul Tan <pyokagan@gmail.com> writes:
> 
>> -	--log|--no-log)
>> -		log_arg=$1 ;;
>> +	--log|--log=*|--no-log)
>> +		log_arg="$1" ;;
> 
> I think you actually don't need the double quotes here (var=$value works
> even if $value has spaces IIRC), but they don't harm and I prefer having
> them.
I am far from a shell expert, but IIRC "$1" converts all whitespace to single spaces. In general, you therefore want to quote arguments, just in case.

Ciao, Dscho

Previous: Matthieu MoyNext: Matthieu Moy
Message 5 of 9 in “teach git pull to handle --log=<n>”
  1. 0/2 teach git pull to handle --log=<n>Paul Tan, May 13, 2015
  2. 1/2 t5524: test --log=1 limits shortlog lengthPaul Tan, May 13, 2015
  3. 2/2 pull: handle --log=<n>Paul Tan, May 13, 2015
  4. Matthieu MoyMay 13, 2015
  5. Johannes SchindelinMay 13, 2015
  6. Matthieu MoyMay 13, 2015
  7. Matthieu MoyMay 13, 2015
  8. Junio C HamanoMay 14, 2015
  9. Paul TanMay 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.