Re: [PATCH 2/2] pull: handle --log=<n>
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- May 13, 2015, 20:03 UTC
- Message-ID
- <vpq3830kzxx.fsf@anie.imag.fr>
- In-Reply-To
- <c8dc145fcc56d38e04fc0e07ceb34999@www.dscho.org>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
Show 16 quoted lines
> Hi Matthieu, > > On 2015-05-13 11:38, Matthieu Moy wrote: >> Paul Tan <pyokagan@gmail.com> writes: >> >>> - --log|--no-log) >>> - log_arg=$1 ;; >>> + --log|--log=*|--no-log) >>> + log_arg="$1" ;; >> >> I think you actually don't need the double quotes here (var=$value works >> even if $value has spaces IIRC), but they don't harm and I prefer having >> them. > > I am far from a shell expert, but IIRC "$1" converts all whitespace to > single spaces.
In most places, $1 is split before being interpreted, but there are exceptions and actually the RHS of assignment is one of them. Just for curiosity, I digged a reference:
https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Shell-Substitutions.html http://unix.stackexchange.com/questions/68694/when-is-double-quoting-necessary
> In general, you therefore want to quote arguments, just in case.
Yes, and one benefit of quoting anyway is to avoid having to have the discussion we're having ;-).
-- Matthieu Moy http://www-verimag.imag.fr/~moy/