From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 13 May 2015 12:23:21 GMT
Subject: Re: [PATCH 2/2] pull: handle --log=<n>
Message-ID: <c8dc145fcc56d38e04fc0e07ceb34999@www.dscho.org>
In-Reply-To: <vpqlhgszujc.fsf@anie.imag.fr>

Hi Matthieu,

On 2015-05-13 11:38, Matthieu Moy wrote:
> Paul Tan <pyokagan@gmail.com> writes:
> 
>> -	--log|--no-log)
>> -		log_arg=$1 ;;
>> +	--log|--log=*|--no-log)
>> +		log_arg="$1" ;;
> 
> I think you actually don't need the double quotes here (var=$value works
> even if $value has spaces IIRC), but they don't harm and I prefer having
> them.

I am far from a shell expert, but IIRC "$1" converts all whitespace to single spaces. In general, you therefore want to quote arguments, just in case.

Ciao,
Dscho