git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] teach git pull to handle --log=<n>

From
Paul Tan <pyokagan@gmail.com>
Date
May 15, 2015, 11:15 UTC
Message-ID
<CACRoPnQ6cH2w=4DRcq+aPGz2ahRaU3Lnabgi5EbAC8BVRPHgzg@mail.gmail.com>
In-Reply-To
<xmqqd22384om.fsf@gitster.dls.corp.google.com>
Hi,
On Fri, May 15, 2015 at 1:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> One advice; for a small patch like this one (and the "pull.ff vs
> merge.ff" one, too), it is not necessary or even desirable to do a
> two-step "first add a failure test and then another patch to fix and
> flip the expectation" series.  Just do the fix and add a test to
> expect success.
>
> After all, the primary reason why we add test is *not* for you to
> demonstrate that what you did works as expected.  It is to catch
> other people breaking what you did in the future.

Since I will be re-rolling all the patches to remove the use of "verbose" I guess I will squash the patches as well.

Thanks.
Previous: Junio C Hamano
Message 9 of 9 in “teach git pull to handle --log=<n>”
  1. 0/2 teach git pull to handle --log=<n>Paul Tan, May 13, 2015
  2. 1/2 t5524: test --log=1 limits shortlog lengthPaul Tan, May 13, 2015
  3. 2/2 pull: handle --log=<n>Paul Tan, May 13, 2015
  4. Matthieu MoyMay 13, 2015
  5. Johannes SchindelinMay 13, 2015
  6. Matthieu MoyMay 13, 2015
  7. Matthieu MoyMay 13, 2015
  8. Junio C HamanoMay 14, 2015
  9. Paul TanMay 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.