Re: [PATCH 3/7] http-push: remove useless condition

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Feb 21, 2010, 15:23 UTC
Message-ID: <be6fef0d1002210723t2cb55460n4dcc1d27ebef03fd@mail.gmail.com>
In-Reply-To: <20100221104015.GB5166@localhost>

Hi,

On Sun, Feb 21, 2010 at 6:40 PM, Clemens Buchacher <drizzd@aon.at> wrote:

Show 8 quoted lines

> On Sun, Feb 21, 2010 at 11:08:24AM +0800, Tay Ray Chuan wrote:
>> -                     if (push_verbosely || 1)
>> +                     if (push_verbosely)
>>                               fprintf(stderr, "'%s': up-to-date\n", ref->name);
>
> Just a minor nit-pick. If you end up doing a resend, maybe you could change
> the commit message to this one, since you're actually adding a condition
> that was previously disabled, not removing it.

yes, that makes sense..

-- 
Cheers,
Ray Chuan