git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/7] http-push: remove useless condition

From
Clemens Buchacher <drizzd@aon.at>
Date
Feb 21, 2010, 10:40 UTC
Message-ID
<20100221104015.GB5166@localhost>
In-Reply-To
<1266721708-1060-4-git-send-email-rctay89@gmail.com>
On Sun, Feb 21, 2010 at 11:08:24AM +0800, Tay Ray Chuan wrote:
> -			if (push_verbosely || 1)
> +			if (push_verbosely)
>  				fprintf(stderr, "'%s': up-to-date\n", ref->name);

Just a minor nit-pick. If you end up doing a resend, maybe you could change the commit message to this one, since you're actually adding a condition that was previously disabled, not removing it.

Clemens
Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 5 of 13 in “http: minor improvements”
  1. 0/7 http: minor improvementsTay Ray Chuan, Feb 21, 2010
  2. 1/7 t5541-http-push: check that ref is unchanged for non-ff testTay Ray Chuan, Feb 21, 2010
  3. 2/7 t554[01]-http-push: refactor, add non-ff testsTay Ray Chuan, Feb 21, 2010
  4. 3/7 http-push: remove useless conditionTay Ray Chuan, Feb 21, 2010
  5. Clemens BuchacherFeb 21, 2010
  6. Tay Ray ChuanFeb 21, 2010
  7. 4/7 http-walker: cleanup more thoroughlyTay Ray Chuan, Feb 21, 2010
  8. 5/7 http: init and cleanup separately from http-walkerTay Ray Chuan, Feb 21, 2010
  9. Clemens BuchacherFeb 21, 2010
  10. Clemens BuchacherFeb 21, 2010
  11. Tay Ray ChuanFeb 21, 2010
  12. 6/7 remote-curl: use http_fetch_ref() instead of walker wrapperTay Ray Chuan, Feb 21, 2010
  13. 7/7 remote-curl: init walker only when neededTay Ray Chuan, Feb 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.