git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] remote-curl: use http_fetch_ref() instead of walker wrapper

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Feb 21, 2010, 03:08 UTC
Message-ID
<1266721708-1060-7-git-send-email-rctay89@gmail.com>
In-Reply-To
<1266721708-1060-1-git-send-email-rctay89@gmail.com>

The http-walker implementation of walker->fetch_ref() doesn't do anything special compared to http_fetch_ref() anyway.

Remove init_walker() invocation before fetching the ref, since we aren't using the walker wrapper and don't need a walker instance anymore.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 remote-curl.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 1e13fb5..5ace99e 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -250,9 +250,8 @@ static struct ref *parse_info_refs(struct discovery *heads)
 		i++;
 	}
 
-	init_walker();
 	ref = alloc_ref("HEAD");
-	if (!walker->fetch_ref(walker, ref) &&
+	if (!http_fetch_ref(url, ref) &&
 	    !resolve_remote_symref(ref, refs)) {
 		ref->next = refs;
 		refs = ref;
-- 
1.7.0.26.gbfa16
Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 12 of 13 in “http: minor improvements”
  1. 0/7 http: minor improvementsTay Ray Chuan, Feb 21, 2010
  2. 1/7 t5541-http-push: check that ref is unchanged for non-ff testTay Ray Chuan, Feb 21, 2010
  3. 2/7 t554[01]-http-push: refactor, add non-ff testsTay Ray Chuan, Feb 21, 2010
  4. 3/7 http-push: remove useless conditionTay Ray Chuan, Feb 21, 2010
  5. Clemens BuchacherFeb 21, 2010
  6. Tay Ray ChuanFeb 21, 2010
  7. 4/7 http-walker: cleanup more thoroughlyTay Ray Chuan, Feb 21, 2010
  8. 5/7 http: init and cleanup separately from http-walkerTay Ray Chuan, Feb 21, 2010
  9. Clemens BuchacherFeb 21, 2010
  10. Clemens BuchacherFeb 21, 2010
  11. Tay Ray ChuanFeb 21, 2010
  12. 6/7 remote-curl: use http_fetch_ref() instead of walker wrapperTay Ray Chuan, Feb 21, 2010
  13. 7/7 remote-curl: init walker only when neededTay Ray Chuan, Feb 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.