Re: [PATCH 5/7] http: init and cleanup separately from http-walker

From: Clemens Buchacher <drizzd@aon.at>
Date: Feb 21, 2010, 10:38 UTC
Message-ID: <20100221103820.GA5166@localhost>
In-Reply-To: <1266721708-1060-6-git-send-email-rctay89@gmail.com>

On Sun, Feb 21, 2010 at 11:08:26AM +0800, Tay Ray Chuan wrote:

> diff --git a/http-fetch.c b/http-fetch.c

[...]

Show 10 quoted lines

> @@ -69,7 +70,8 @@ int main(int argc, const char **argv)
>  		url = rewritten_url;
>  	}
>  
> -	walker = get_http_walker(url, NULL);
> +	http_init(NULL);
> +	walker = get_http_walker(url);
>  	walker->get_tree = get_tree;
>  	walker->get_history = get_history;
>  	walker->get_all = get_all;

You changed the order of get_http_walker and http_init. But

        add_fill_function(walker, (int (*)(void *)) fill_active_slot);

already deals with curl functionality. So even though I think it technically doesn't break, I would prefer if this dependency were still expressed in the code.

Show 8 quoted lines

> @@ -88,6 +90,7 @@ int main(int argc, const char **argv)
>  "status code.  Suggest running 'git fsck'.\n");
>  	}
>  
> +	http_cleanup();
>  	walker_free(walker);
>  
>  	free(rewritten_url);

Same as above.

Otherwise the series looks good to me.

Liked-by: Clemens Buchacher <drizzd@aon.at>

Clemens