Re: [PATCH] rebase docs: fix incorrect format of the section Behavioral Differences
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 5, 2018, 21:16 UTC
- Message-ID
- <bd67cd33-dbe8-03a0-e760-c7bb23854084@kdbg.org>
- In-Reply-To
- <CABPp-BHzESYnQy5JwXvtXyLHgHR9u3UNVOZF2gU1m_uTMGkyfg@mail.gmail.com>
Am 05.12.18 um 16:37 schrieb Elijah Newren:
Show 23 quoted lines
> On Tue, Dec 4, 2018 at 11:40 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> Johannes Sixt <j6t@kdbg.org> writes: >> >>> Please let me deposit my objection. This paragraph is not the right >>> place to explain what directory renme detection is and how it works >>> under the hood. "works fine" in the original text is the right phrase >>> here; if there is concern that this induces expectations that cannot >>> be met, throw in the word "heuristics". >>> >>> Such as: >>> Directory rename heuristics work fine in the merge and interactive >>> backends. It does not in the am backend because... >> >> OK, good enough, I guess. Or just s/work fine/is enabled/. > > So... > > Directory rename heuristics are enabled in the merge and interactive > backends. They are not in the am backend because it operates on > "fake ancestors" that involve trees containing only the files modified > in the patch. Due to the lack of accurate tree information, directory > rename detection is disabled for the am backend.
OK with me. And also if you drop sentence no.2 and keep just no.1 and no.3.
Thanks, -- Hannes