git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase docs: fix incorrect format of the section Behavioral Differences

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 5, 2018, 22:46 UTC
Message-ID
<xmqqmupjbnhq.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<bd67cd33-dbe8-03a0-e760-c7bb23854084@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 26 quoted lines
> Am 05.12.18 um 16:37 schrieb Elijah Newren:
>> On Tue, Dec 4, 2018 at 11:40 PM Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>> Johannes Sixt <j6t@kdbg.org> writes:
>>>
>>>> Please let me deposit my objection. This paragraph is not the right
>>>> place to explain what directory renme detection is and how it works
>>>> under the hood. "works fine" in the original text is the right phrase
>>>> here; if there is concern that this induces expectations that cannot
>>>> be met, throw in the word "heuristics".
>>>>
>>>> Such as:
>>>>     Directory rename heuristics work fine in the merge and interactive
>>>>     backends. It does not in the am backend because...
>>>
>>> OK, good enough, I guess.  Or just s/work fine/is enabled/.
>>
>> So...
>>
>> Directory rename heuristics are enabled in the merge and interactive
>> backends. They are not in the am backend because it operates on
>> "fake ancestors" that involve trees containing only the files modified
>> in the patch.  Due to the lack of accurate tree information, directory
>> rename detection is disabled for the am backend.
>
> OK with me. And also if you drop sentence no.2 and keep just no.1 and no.3.

Yeah, that shorter version may be sufficient to explain why we do not use the heuristics in the "am" backend.

Previous: Johannes SixtNext: Johannes Sixt
Message 15 of 18 in “rebase docs: fix incorrect format of the section Behavioral Differences”
  1. rebase docs: fix incorrect format of the section Behavioral DifferencesJohannes Sixt, Dec 3, 2018
  2. Martin ÅgrenDec 3, 2018
  3. Johannes SixtDec 3, 2018
  4. Junio C HamanoDec 4, 2018
  5. Johannes SchindelinDec 3, 2018
  6. Elijah NewrenDec 4, 2018
  7. Johannes SixtDec 4, 2018
  8. Elijah NewrenDec 4, 2018
  9. Junio C HamanoDec 5, 2018
  10. Elijah NewrenDec 5, 2018
  11. Johannes SixtDec 5, 2018
  12. Junio C HamanoDec 5, 2018
  13. Elijah NewrenDec 5, 2018
  14. Johannes SixtDec 5, 2018
  15. Junio C HamanoDec 5, 2018
  16. git-rebase.txt: update note about directory rename detection and amJohannes Sixt, Dec 7, 2018
  17. Elijah NewrenDec 7, 2018
  18. Junio C HamanoDec 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.