From: Johannes Sixt Date: Wed, 05 Dec 2018 21:16:27 GMT Subject: Re: [PATCH] rebase docs: fix incorrect format of the section Behavioral Differences Message-ID: In-Reply-To: Am 05.12.18 um 16:37 schrieb Elijah Newren: > On Tue, Dec 4, 2018 at 11:40 PM Junio C Hamano wrote: >> >> Johannes Sixt writes: >> >>> Please let me deposit my objection. This paragraph is not the right >>> place to explain what directory renme detection is and how it works >>> under the hood. "works fine" in the original text is the right phrase >>> here; if there is concern that this induces expectations that cannot >>> be met, throw in the word "heuristics". >>> >>> Such as: >>> Directory rename heuristics work fine in the merge and interactive >>> backends. It does not in the am backend because... >> >> OK, good enough, I guess. Or just s/work fine/is enabled/. > > So... > > Directory rename heuristics are enabled in the merge and interactive > backends. They are not in the am backend because it operates on > "fake ancestors" that involve trees containing only the files modified > in the patch. Due to the lack of accurate tree information, directory > rename detection is disabled for the am backend. OK with me. And also if you drop sentence no.2 and keep just no.1 and no.3. Thanks, -- Hannes