git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-rebase.txt: update note about directory rename detection and am

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 9, 2018, 00:22 UTC
Message-ID
<xmqq8t0z7dmi.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CABPp-BGSmyAb_d52TLS=7oQyMYxt=EYjNdDofY4nzLd9CYvwuQ@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 34 quoted lines
> On Fri, Dec 7, 2018 at 9:51 AM Johannes Sixt <j6t@kdbg.org> wrote:
>>
>> From: Elijah Newren <newren@gmail.com>
>>
>> In commit 6aba117d5cf7 ("am: avoid directory rename detection when
>> calling recursive merge machinery", 2018-08-29), the git-rebase manpage
>> probably should have also been updated to note the stronger
>> incompatibility between git-am and directory rename detection.  Update
>> it now.
>>
>> Signed-off-by: Elijah Newren <newren@gmail.com>
>> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>> ---
>>   Documentation/git-rebase.txt | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
>> index 41631df6e4..7bea21e8e3 100644
>> --- a/Documentation/git-rebase.txt
>> +++ b/Documentation/git-rebase.txt
>> @@ -569,8 +569,9 @@ it to keep commits that started empty.
>>   Directory rename detection
>>   ~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> -The merge and interactive backends work fine with
>> -directory rename detection.  The am backend sometimes does not.
>> +Directory rename heuristics are enabled in the merge and interactive
>> +backends.  Due to the lack of accurate tree information, directory
>> +rename detection is disabled in the am backend.
>>
>>   include::merge-strategies.txt[]
>
> I was intending to send this out the past couple days, was just kinda
> busy.  Thanks for handling it for me.

Thanks, both. I can live with format=flowed, but would appreciate if we can avoid it next time.

Previous: Elijah Newren
Message 18 of 18 in “rebase docs: fix incorrect format of the section Behavioral Differences”
  1. rebase docs: fix incorrect format of the section Behavioral DifferencesJohannes Sixt, Dec 3, 2018
  2. Martin ÅgrenDec 3, 2018
  3. Johannes SixtDec 3, 2018
  4. Junio C HamanoDec 4, 2018
  5. Johannes SchindelinDec 3, 2018
  6. Elijah NewrenDec 4, 2018
  7. Johannes SixtDec 4, 2018
  8. Elijah NewrenDec 4, 2018
  9. Junio C HamanoDec 5, 2018
  10. Elijah NewrenDec 5, 2018
  11. Johannes SixtDec 5, 2018
  12. Junio C HamanoDec 5, 2018
  13. Elijah NewrenDec 5, 2018
  14. Johannes SixtDec 5, 2018
  15. Junio C HamanoDec 5, 2018
  16. git-rebase.txt: update note about directory rename detection and amJohannes Sixt, Dec 7, 2018
  17. Elijah NewrenDec 7, 2018
  18. Junio C HamanoDec 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.