git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/6] t3404: remove unnecessary subshell

From
PGPhillip Wood via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 15, 2019, 10:25 UTC
Message-ID
<b9689e85e593062f4d82cb955f36c8ef65ad0c4e.1571135132.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.388.v2.git.1571135132.gitgitgadget@gmail.com>
From: Phillip Wood <phillip.wood@dunelm.org.uk>

Neither of the commands executed in the subshell change any shell variables or the current directory so there is no need for them to be executed in a subshell.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
---
 t/t3404-rebase-interactive.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index d2f1d5bd23..c26b3362ef 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -945,10 +945,8 @@ test_expect_success C_LOCALE_OUTPUT 'rebase -ix with --autosquash' '
 	git add bis.txt &&
 	git commit -m "fixup! two_exec" &&
 	set_fake_editor &&
-	(
-		git checkout -b autosquash_actual &&
-		git rebase -i --exec "git show HEAD" --autosquash HEAD~4 >actual
-	) &&
+	git checkout -b autosquash_actual &&
+	git rebase -i --exec "git show HEAD" --autosquash HEAD~4 >actual &&
 	git checkout autosquash &&
 	(
 		git checkout -b autosquash_expected &&

-- 
gitgitgadget
Previous: Phillip Wood via GitGitGadgetNext: Phillip Wood via GitGitGadget
Message 13 of 20 in “sequencer: start running post-commit hook again”
  1. 0/3 sequencer: start running post-commit hook againPhillip Wood via GitGitGadget, Oct 10, 2019
  2. 2/3 sequencer: use run_commit_hook()Phillip Wood via GitGitGadget, Oct 10, 2019
  3. Johannes SchindelinOct 10, 2019
  4. Junio C HamanoOct 11, 2019
  5. Phillip WoodOct 14, 2019
  6. Johannes SchindelinOct 14, 2019
  7. 1/3 sequencer.h fix placement of #endifPhillip Wood via GitGitGadget, Oct 10, 2019
  8. 3/3 sequencer: run post-commit hookPhillip Wood via GitGitGadget, Oct 10, 2019
  9. Johannes SchindelinOct 10, 2019
  10. Junio C HamanoOct 11, 2019
  11. Phillip WoodOct 11, 2019
  12. 0/6 sequencer: start running post-commit hook againPhillip Wood via GitGitGadget, Oct 15, 2019
  13. 1/6 t3404: remove unnecessary subshellPhillip Wood via GitGitGadget, Oct 15, 2019
  14. 2/6 t3404: set $EDITOR in subshellPhillip Wood via GitGitGadget, Oct 15, 2019
  15. 3/6 t3404: remove uneeded calls to set_fake_editorPhillip Wood via GitGitGadget, Oct 15, 2019
  16. 6/6 sequencer: run post-commit hookPhillip Wood via GitGitGadget, Oct 15, 2019
  17. 4/6 sequencer.h fix placement of #endifPhillip Wood via GitGitGadget, Oct 15, 2019
  18. 5/6 move run_commit_hook() to libgit and use it therePhillip Wood via GitGitGadget, Oct 15, 2019
  19. Johannes SchindelinOct 15, 2019
  20. Junio C HamanoOct 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.