git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 6/6] sequencer: run post-commit hook

From
PGPhillip Wood via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 15, 2019, 10:25 UTC
Message-ID
<67a711754efce038914e8ec15c5dec4a5983566d.1571135132.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.388.v2.git.1571135132.gitgitgadget@gmail.com>
From: Phillip Wood <phillip.wood@dunelm.org.uk>

Prior to commit 356ee4659b ("sequencer: try to commit without forking 'git commit'", 2017-11-24) the sequencer would always run the post-commit hook after each pick or revert as it forked `git commit` to create the commit. The conversion to committing without forking `git commit` omitted to call the post-commit hook after creating the commit.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
---
 sequencer.c                   |  1 +
 t/t3404-rebase-interactive.sh | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)
diff --git a/sequencer.c b/sequencer.c
index cdc0d1dfba..da2decbd3a 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -1401,6 +1401,7 @@ static int try_to_commit(struct repository *r,
 		goto out;
 	}
 
+	run_commit_hook(0, r->index_file, "post-commit", NULL);
 	if (flags & AMEND_MSG)
 		commit_post_rewrite(r, current_head, oid);
 
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index c5d0326825..c573c99069 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -1583,6 +1583,25 @@ test_expect_success 'valid author header when author contains single quote' '
 	test_cmp expected actual
 '
 
+test_expect_success 'post-commit hook is called' '
+	test_when_finished "rm -f .git/hooks/post-commit" &&
+	>actual &&
+	mkdir -p .git/hooks &&
+	write_script .git/hooks/post-commit <<-\EOS &&
+	git rev-parse HEAD >>actual
+	EOS
+	(
+		set_fake_editor &&
+		FAKE_LINES="edit 4 1 reword 2 fixup 3" git rebase -i A E &&
+		echo x>file3 &&
+		git add file3 &&
+		FAKE_COMMIT_MESSAGE=edited git rebase --continue
+	) &&
+	git rev-parse HEAD@{5} HEAD@{4} HEAD@{3} HEAD@{2} HEAD@{1} HEAD \
+		>expect &&
+	test_cmp expect actual
+'
+
 # This must be the last test in this file
 test_expect_success '$EDITOR and friends are unchanged' '
 	test_editor_unchanged
-- 
gitgitgadget
Previous: Phillip Wood via GitGitGadgetNext: Phillip Wood via GitGitGadget
Message 16 of 20 in “sequencer: start running post-commit hook again”
  1. 0/3 sequencer: start running post-commit hook againPhillip Wood via GitGitGadget, Oct 10, 2019
  2. 2/3 sequencer: use run_commit_hook()Phillip Wood via GitGitGadget, Oct 10, 2019
  3. Johannes SchindelinOct 10, 2019
  4. Junio C HamanoOct 11, 2019
  5. Phillip WoodOct 14, 2019
  6. Johannes SchindelinOct 14, 2019
  7. 1/3 sequencer.h fix placement of #endifPhillip Wood via GitGitGadget, Oct 10, 2019
  8. 3/3 sequencer: run post-commit hookPhillip Wood via GitGitGadget, Oct 10, 2019
  9. Johannes SchindelinOct 10, 2019
  10. Junio C HamanoOct 11, 2019
  11. Phillip WoodOct 11, 2019
  12. 0/6 sequencer: start running post-commit hook againPhillip Wood via GitGitGadget, Oct 15, 2019
  13. 1/6 t3404: remove unnecessary subshellPhillip Wood via GitGitGadget, Oct 15, 2019
  14. 2/6 t3404: set $EDITOR in subshellPhillip Wood via GitGitGadget, Oct 15, 2019
  15. 3/6 t3404: remove uneeded calls to set_fake_editorPhillip Wood via GitGitGadget, Oct 15, 2019
  16. 6/6 sequencer: run post-commit hookPhillip Wood via GitGitGadget, Oct 15, 2019
  17. 4/6 sequencer.h fix placement of #endifPhillip Wood via GitGitGadget, Oct 15, 2019
  18. 5/6 move run_commit_hook() to libgit and use it therePhillip Wood via GitGitGadget, Oct 15, 2019
  19. Johannes SchindelinOct 15, 2019
  20. Junio C HamanoOct 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.