Re: [PATCH 2/3] sequencer: use run_commit_hook()
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Oct 14, 2019, 13:26 UTC
- Message-ID
- <7a56faf1-a0e3-98ad-bdfe-e9ba0b97b5c2@gmail.com>
- In-Reply-To
- <xmqqk19bj4dk.fsf@gitster-ct.c.googlers.com>
Hi Dscho & Junio
On 11/10/2019 05:24, Junio C Hamano wrote:
Show 12 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > >>> builtin/commit.c | 22 ---------------------- >>> commit.h | 3 --- >>> sequencer.c | 45 ++++++++++++++++++++++++++++++++++----------- >>> sequencer.h | 2 ++ >>> 4 files changed, 36 insertions(+), 36 deletions(-) >> >> Hmm. I would have thought that `commit.c` would be a more logical home >> for that function (and that the declaration could remain in `commit.h`)? > > Good correction.
There are some other public commit related functions in sequencer.c - print_commit_summary(), commit_post_rewrite(), rest_is_empty(), cleanup_message(), message_is_empty(), template_untouched(), update_head_with_reflog() . Would you like to see them moved to commit.c (probably as a separate series)?
Best Wishes
Phillip
> > Thanks. >