Re: [PATCH] Avoid errors from git-rev-parse in gitweb blame

From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Jun 3, 2008, 13:36 UTC
Message-ID: <b77c1dce0806030636i434e4716r8a52d6aeb93e9719@mail.gmail.com>
In-Reply-To: <200806031512.20729.jnareb@gmail.com>

2008/6/3 Jakub Narebski <jnareb@gmail.com>:

Show 14 quoted lines

>>
>> OK, I see. That would be nice. Also: currently taking "$full_rev^"
>> directs the user to the parent commit, but it would be more
>> user-friendly to point at the previous commit where the selected file
>> was modified instead.
>
> That's what I meant by distinguishing between 'parents' and
> 'original-parents' (or 'rewritten-parents' and 'parents'): first are
> rewritten parents in history limited to specified file (with the
> addition of code movements and copying across files/filenames),
> second are original parents of a commit.
>
> For gitweb we would use the first set (I wonder what to do in the case
> of merge commit, i.e. more than one parent).

Currently that takes the left parent. Or something.

Shameless plug : the sources for perl 5 are currently being kept in a perforce repository. There is a rough web interface to it at http://public.activestate.com/cgi-bin/perlbrowse with excellent blame log navigation features (including navigation against p4 integrations).

Since we're going to move the official perl 5 vcs to git (many many thanks to Sam Vilain for that, BTW), I'm more or less trying to duplicate this blame log navigation in gitweb. So it might result in a few patches here :)