Re: [PATCH] Avoid errors from git-rev-parse in gitweb blame

From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Jun 3, 2008, 12:03 UTC
Message-ID: <b77c1dce0806030503r55c95d73t5ff244821f76cf1@mail.gmail.com>
In-Reply-To: <m34p8a2173.fsf@localhost.localdomain>

2008/6/3 Jakub Narebski <jnareb@gmail.com>:

Show 11 quoted lines

>> -             open (my $dd, "-|", git_cmd(), "rev-parse", "$full_rev^")
>> +             open (my $dd, "-|", git_cmd(), "rev-parse", '--revs-only', "$full_rev^")
>>                       or die_error(undef, "Open git-rev-parse failed");
>> -             my $parent_commit = <$dd>;
>> +             my $parent_commit = <$dd> || '';
>>               close $dd;
>>               chomp($parent_commit);
>>               my $blamed = href(action => 'blame',
>
> I'd rather remove this, correct it, or make it optional (this is very
> fork-heavy).

Not sure how to do the same thing in pure perl. We could however cache the results of git-rev-parse, since the same rev is likely to appear many times in the list.