Re: [PATCH] Avoid errors from git-rev-parse in gitweb blame

From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Jun 3, 2008, 13:00 UTC
Message-ID: <b77c1dce0806030600x520d35edxbe6e732ce6cc4ad6@mail.gmail.com>
In-Reply-To: <200806031445.23002.jnareb@gmail.com>

2008/6/3 Jakub Narebski <jnareb@gmail.com>:

Show 8 quoted lines

>>> I'd rather remove this, correct it, or make it optional (this is very
>>> fork-heavy).
>>
>> Not sure how to do the same thing in pure Perl.
>
> I was thinking about extending git-blame porcelain format (and also
> incremental format, of course) by 'parents' (and perhaps
> 'original-parents') header...

OK, I see. That would be nice. Also: currently taking "$full_rev^" directs the user to the parent commit, but it would be more user-friendly to point at the previous commit where the selected file was modified instead.

Show 8 quoted lines

>> We could however cache the results of git-rev-parse, since the same
>> rev is likely to appear many times in the list.
>
> ...but starting with cache of git-rev-parse results, or optionally
> allowing extended sha-1 syntax (including <hash>^) in hash* CGI
> parameters in gitweb would be a good idea.
>
> But as I wrote, I'm fine with the patch as it is now.

I've sent a new version (take 2) with caching. And comments, as Lea suggested :)