git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] fetch: do not override partial clone filter

From
Derrick Stolee <stolee@gmail.com>
Date
Sep 22, 2020, 11:35 UTC
Message-ID
<b59f00b6-2787-261e-a295-35eb4a6f442b@gmail.com>
In-Reply-To
<xmqq363acqj9.fsf@gitster.c.googlers.com>
On 9/22/2020 1:46 AM, Junio C Hamano wrote:
Show 8 quoted lines
> Jonathan Tan <jonathantanmy@google.com> writes:
> 
>> +test_expect_success 'ensure that filter is written to config' '
>> +	FILTER=$(git -C client config --get remote.blah.partialclonefilter) &&
>> +	test "$FILTER" == "blob:limit=0"
> 
> I'll do s/==/=/ locally because otherwise the test-lint-shell-syntax
> will choke on this line.  No need to resend only this line.

Wouldn't "test_cmp_config" be a better here? It seems like this is testing the "git clone" behavior of the previous test, so it could be added to that test instead.

Thanks, -Stolee

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “Fix overriding of partial clone filter when lazy-fetching”
  1. 0/2 Fix overriding of partial clone filter when lazy-fetchingJonathan Tan, Sep 22, 2020
  2. 2/2 fetch: do not override partial clone filterJonathan Tan, Sep 22, 2020
  3. Junio C HamanoSep 22, 2020
  4. Derrick StoleeSep 22, 2020
  5. Junio C HamanoSep 22, 2020
  6. 1/2 promisor-remote: remove unused variableJonathan Tan, Sep 22, 2020
  7. Junio C HamanoSep 22, 2020
  8. 0/2 Fix overriding of partial clone filter when lazy-fetchingJonathan Tan, Sep 28, 2020
  9. 2/2 fetch: do not override partial clone filterJonathan Tan, Sep 28, 2020
  10. Junio C HamanoSep 28, 2020
  11. 1/2 promisor-remote: remove unused variableJonathan Tan, Sep 28, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.