From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 22 Sep 2020 11:35:12 GMT
Subject: Re: [PATCH 2/2] fetch: do not override partial clone filter
Message-ID: <b59f00b6-2787-261e-a295-35eb4a6f442b@gmail.com>
In-Reply-To: <xmqq363acqj9.fsf@gitster.c.googlers.com>

On 9/22/2020 1:46 AM, Junio C Hamano wrote:
> Jonathan Tan <jonathantanmy@google.com> writes:
> 
>> +test_expect_success 'ensure that filter is written to config' '
>> +	FILTER=$(git -C client config --get remote.blah.partialclonefilter) &&
>> +	test "$FILTER" == "blob:limit=0"
> 
> I'll do s/==/=/ locally because otherwise the test-lint-shell-syntax
> will choke on this line.  No need to resend only this line.

Wouldn't "test_cmp_config" be a better here? It seems like
this is testing the "git clone" behavior of the previous test,
so it could be added to that test instead.

Thanks,
-Stolee