Re: [PATCH 0/2] Fix overriding of partial clone filter when lazy-fetching

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 22, 2020, 05:45 UTC
Message-ID: <xmqq7dsmcqkp.fsf@gitster.c.googlers.com>
In-Reply-To: <cover.1600743698.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> This was noticed at $DAYJOB when in a partial clone with a filter other
> than blob:none. The 1st patch is a code cleanup (so that the 2nd patch
> does not need to take into account the unused variable), and the 2nd
> patch contains the bug fix.

What is "this" is not clear at all. This is one of those cover letters unfriendly to readers who do not know what the author did before being told X-<. We got a vague "we found some unspecified bug and fixed it, and we need to read them through if we want to find out what it is".

Show 11 quoted lines

>
> Jonathan Tan (2):
>   promisor-remote: remove unused variable
>   fetch: do not override partial clone filter
>
>  builtin/fetch.c               |  2 +-
>  list-objects-filter-options.c | 10 +++++++++-
>  promisor-remote.c             |  5 -----
>  promisor-remote.h             |  2 +-
>  t/t5601-clone.sh              |  5 +++++
>  5 files changed, 16 insertions(+), 8 deletions(-)