git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] fetch: do not override partial clone filter

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 28, 2020, 23:43 UTC
Message-ID
<xmqq1riljwmq.fsf@gitster.c.googlers.com>
In-Reply-To
<c3ced598751ae8fe7b7b6e787474331cf8219802.1601331788.git.jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 6 quoted lines
>  test_expect_success 'partial clone with -o' '
>  	partial_clone_server server &&
> -	git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
> +	git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client &&
> +	test_cmp_config -C client "blob:limit=0" --get-all remote.blah.partialclonefilter
>  '

Makes sense to piggyback on this existing test. It also makes sense to ensure that the original one is all and the only filter that is being configured.

Will queue.  Let's merge them to 'next'.
Previous: Jonathan TanNext: Jonathan Tan
Message 10 of 11 in “Fix overriding of partial clone filter when lazy-fetching”
  1. 0/2 Fix overriding of partial clone filter when lazy-fetchingJonathan Tan, Sep 22, 2020
  2. 2/2 fetch: do not override partial clone filterJonathan Tan, Sep 22, 2020
  3. Junio C HamanoSep 22, 2020
  4. Derrick StoleeSep 22, 2020
  5. Junio C HamanoSep 22, 2020
  6. 1/2 promisor-remote: remove unused variableJonathan Tan, Sep 22, 2020
  7. Junio C HamanoSep 22, 2020
  8. 0/2 Fix overriding of partial clone filter when lazy-fetchingJonathan Tan, Sep 28, 2020
  9. 2/2 fetch: do not override partial clone filterJonathan Tan, Sep 28, 2020
  10. Junio C HamanoSep 28, 2020
  11. 1/2 promisor-remote: remove unused variableJonathan Tan, Sep 28, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.