Re: [PATCH v2 1/3] config: add git_config_append_parameter()

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 7, 2026, 13:24 UTC
Message-ID: <b395ea0d-37aa-471a-a70a-6b2c278ad64e@gmail.com>
In-Reply-To: <ap5yT0sOtLQQa4AY@pks.im>

On 07/09/2026 09:14, Patrick Steinhardt wrote:

Show 15 quoted lines

> On Fri, Sep 04, 2026 at 03:51:24PM +0000, Thomas Bachem via GitGitGadget wrote:
>> From: Thomas Bachem <mail@thomasbachem.com>
>>
>> diff --git a/config.c b/config.c
>> index d9019e7e6c..e0bb29b53d 100644
>> --- a/config.c
>> +++ b/config.c
>> @@ -450,18 +450,24 @@ static int git_config_include(const char *var, const char *value,
>>   	return ret;
>>   }
>>   
>> +void git_config_append_parameter(struct strbuf *env, const char *key,
> 
> Nit: callling this `env` assumes a bit too much about what this buffer
> is going to be used for. I'd have called it just `buf`.

Are we ever likely to use this outside of GIT_CONFIG_PARAMETERS? If not then I think env is a good name because it hints at where this function is used. Isn't the whole point of this function to allow us to append settings an environment variable?

Thanks

Phillip