git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] sequencer: run auto maintenance once a sequence is done

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 8, 2026, 05:50 UTC
Message-ID
<ap-iEoeY7XKjeZgL@pks.im>
In-Reply-To
<CAA0xjtqy3jOPWAGL9Cr0B+VnHAkZF0=cVCxKNqMiVJpfbdpomA@mail.gmail.com>
On Mon, Sep 07, 2026 at 06:35:20PM +0200, Thomas Bachem wrote:
> On 07/09/2026 10:14, Patrick Steinhardt wrote:
[snip]
Show 23 quoted lines
> > It's surprisingly many sites where you add the call to
> > `run_auto_maintenance()`. My hope was that there is a single exit path
> > somewhere that is used by both the "apply" and "merge" strategy that we
> > could adapt to unify when exactly we run auto-maintenance across both
> > backends.
> 
> There is none inside the sequencer. run_specific_rebase() calls
> finish_rebase() for the apply backend only,
> "merge backend cleans up after itself" as the comment there says.
> Sequences end inside pick_commits(), and a single cherry-pick or
> revert never creates sequencer state at all and returns straight to
> builtin/revert.c. That is where the three sites come from.
> 
> I could instead do what the apply backend already does. am.c skips
> maintenance in rebasing mode and leaves it to rebase.c. If the
> sequencer leaves it to its callers the same way, run_specific_rebase()
> runs it for the merge backend too, once its state directory is gone,
> and run_sequencer() in builtin/revert.c runs it for cherry-pick and
> revert. Every entry into the merge backend returns through
> run_specific_rebase(), --continue and --skip included, so nothing is
> missed. The sequencer then never runs it, the change is in the two
> builtins only, and the rule is short: the command runs it once when it
> is done, and nothing it spawns does. Is that what you had in mind?

Maybe. The question is what kind of impact it would have on other subsystems. I think the most important part that I'm after is that the commit message explains design decisions like this, as it gives the reader the required context to be able to evaluate the patch.

And please stay mindful of LLM-generated commit messages. For most of the part they are just completely useless as they tend to ramble without conveying any useful information. The commit message is the place where you yourself sell the change to us, and by explaining the changes well you demonstrate that you understand what you're sending to the mailing list.

An LLM-generated commit message on the other side demonstrates nothing like that. So in many cases, it's actively hurting your own mission as people do notice that it's not generated by humans.

It's fine to use LLMs to help you with drafting the commit message. But what we're asking is that you double or even triple check what was generated and whether the generated message (1) makes sense and (2) is understandable by a normal human being.

Thanks!
Patrick
Previous: Thomas BachemNext: Thomas Bachem
Message 16 of 52 in “sequencer: leave auto maintenance to the end of a rebase”
  1. 0/2 sequencer: leave auto maintenance to the end of a rebaseThomas Bachem via GitGitGadget, Sep 4, 2026
  2. 1/2 sequencer: run auto maintenance once a rebase is doneThomas Bachem via GitGitGadget, Sep 4, 2026
  3. Phillip WoodSep 4, 2026
  4. 2/2 sequencer: keep auto maintenance out of the commands a rebase spawnsThomas Bachem via GitGitGadget, Sep 4, 2026
  5. Phillip WoodSep 4, 2026
  6. Thomas BachemSep 4, 2026
  7. 0/3 sequencer: leave auto maintenance to the end of a sequenceThomas Bachem via GitGitGadget, Sep 4, 2026
  8. 1/3 config: add git_config_append_parameter()Thomas Bachem via GitGitGadget, Sep 4, 2026
  9. Patrick SteinhardtSep 7, 2026
  10. Phillip WoodSep 7, 2026
  11. Patrick SteinhardtSep 7, 2026
  12. Thomas BachemSep 7, 2026
  13. 2/3 sequencer: run auto maintenance once a sequence is doneThomas Bachem via GitGitGadget, Sep 4, 2026
  14. Patrick SteinhardtSep 7, 2026
  15. Thomas BachemSep 7, 2026
  16. Patrick SteinhardtSep 8, 2026
  17. Thomas BachemSep 8, 2026
  18. Phillip WoodSep 7, 2026
  19. Thomas BachemSep 7, 2026
  20. Phillip WoodSep 7, 2026
  21. 3/3 sequencer: keep auto maintenance out of the commands a sequence spawnsThomas Bachem via GitGitGadget, Sep 4, 2026
  22. Junio C HamanoSep 4, 2026
  23. Thomas BachemSep 5, 2026
  24. Patrick SteinhardtSep 7, 2026
  25. Thomas BachemSep 7, 2026
  26. Phillip WoodSep 7, 2026
  27. Thomas BachemSep 7, 2026
  28. 0/3 sequencer: leave auto maintenance to the end of a sequenceThomas Bachem via GitGitGadget, Sep 8, 2026
  29. 1/3 config: add git_config_append_parameter()Thomas Bachem via GitGitGadget, Sep 8, 2026
  30. 2/3 rebase, cherry-pick, revert: run auto maintenance when doneThomas Bachem via GitGitGadget, Sep 8, 2026
  31. 3/3 sequencer: disable auto maintenance in spawned commandsThomas Bachem via GitGitGadget, Sep 8, 2026
  32. Junio C HamanoSep 8, 2026
  33. Kristoffer HaugsbakkSep 8, 2026
  34. Patrick SteinhardtSep 9, 2026
  35. Thomas BachemSep 10, 2026
  36. 0/3 sequencer: leave auto maintenance to the end of a sequenceThomas Bachem via GitGitGadget, Sep 9, 2026
  37. 1/3 config: add git_config_append_parameter()Thomas Bachem via GitGitGadget, Sep 9, 2026
  38. Patrick SteinhardtSep 11, 2026
  39. Thomas BachemSep 14, 2026
  40. 2/3 rebase, cherry-pick, revert: run auto maintenance when doneThomas Bachem via GitGitGadget, Sep 9, 2026
  41. Patrick SteinhardtSep 11, 2026
  42. Thomas BachemSep 14, 2026
  43. Thomas BachemSep 22, 2026
  44. 3/3 sequencer: disable auto maintenance in spawned commandsThomas Bachem via GitGitGadget, Sep 9, 2026
  45. Phillip WoodSep 9, 2026
  46. Thomas BachemSep 14, 2026
  47. 0/3 sequencer: leave auto maintenance to the end of a sequenceThomas Bachem via GitGitGadget, Sep 17, 2026
  48. 1/3 config: add git_config_append_parameter()Thomas Bachem via GitGitGadget, Sep 17, 2026
  49. 2/3 rebase, cherry-pick, revert: run auto maintenance when doneThomas Bachem via GitGitGadget, Sep 17, 2026
  50. 3/3 sequencer: disable auto maintenance in spawned commandsThomas Bachem via GitGitGadget, Sep 17, 2026
  51. Phillip WoodSep 23, 2026
  52. Patrick SteinhardtSep 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.