Re: [PATCH 2/2] sequencer: keep auto maintenance out of the commands a rebase spawns

From: Thomas Bachem <mail@thomasbachem.com>
Date: Sep 4, 2026, 15:55 UTC
Message-ID: <CAA0xjto-UKzHT2he5U25_G1B__z59jHdgit7A6Za7U=htra3ag@mail.gmail.com>
In-Reply-To: <f44765f2-d04f-4adc-b5f0-56a22658626b@gmail.com>

Hi Phillip,

On 04/09/2026 16:03, Phillip Wood wrote:

> That's what we'll find out when this is merged.

Agreed, and the message now says so instead of claiming it.

> I'm inclined to think that the reasoning for running maintenance at the
> end of a rebase applies to cherry-pick and probably revert as well.

Agreed. In v2 all three end with one run where the sequencer finishes, and none of the commands they spawn run it, the "git commit" of a "cherry-pick --continue" included.

Show 5 quoted lines

> I wonder if we could factor out a helper append the parameters to an
> strbuf passed by the caller so we don't need to know about the quoting
> scheme here. Also it would be nice to cache this in replay_ctx so we
> don't have to construct the string each time we want to disable auto
> maintenance.

Done, as a small config.c patch in front of the two, and a strbuf in replay_ctx built on first use.

The messages are rewritten from scratch and much shorter, the sentence you could not parse included.

Thanks, Thomas