git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] init: show absolute path of (re)initialized repository

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 23, 2026, 06:26 UTC
Message-ID
<atr-Juww5KZN-ugM@pks.im>
In-Reply-To
<20261022120749.3567828-1-m@lfurio.us>
On Thu, Oct 22, 2026 at 08:06:32AM -0400, Matt Hunter wrote:
Show 10 quoted lines
> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index f1d227f27167..fbf8a0e41dad 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -1000,4 +1000,10 @@ test_expect_success 'init honors GIT_OBJECT_DIRECTORY' '
>  	test_path_is_dir custom-odb/info
>  '
>  
> +test_expect_success 'init shows absolute path to gitdir' '
> +	expect="$(pwd)/init-path" &&
I don't think this extra variable buys us anything, so I'd just drop it.
> +	git init init-path >actual &&
> +	test_grep "$expect" actual
> +'

I would have tested for the whole message, which is short enough to be reasonable, I'd say.

Other than those nits I'm happy, thanks!
Patrick
Previous: Matt HunterNext: Matt Hunter
Message 10 of 15 in “init: show absolute path of (re)initialized repository”
  1. init: show absolute path of (re)initialized repositoryMatt Hunter, Oct 20, 2026
  2. Patrick SteinhardtOct 20, 2026
  3. Matt HunterOct 20, 2026
  4. Patrick SteinhardtOct 20, 2026
  5. Harald NordgrenOct 20, 2026
  6. Patrick SteinhardtOct 20, 2026
  7. Harald NordgrenOct 20, 2026
  8. Junio C HamanoOct 20, 2026
  9. init: show absolute path of (re)initialized repositoryMatt Hunter, Oct 22, 2026
  10. Patrick SteinhardtOct 23, 2026
  11. Matt HunterOct 23, 2026
  12. Patrick SteinhardtOct 26, 2026
  13. init: show absolute path of (re)initialized repositoryMatt Hunter, Oct 28, 2026
  14. Patrick SteinhardtOct 28, 2026
  15. Junio C HamanoOct 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.