Re: [PATCH] init: show absolute path of (re)initialized repository
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2026, 16:29 UTC
- Message-ID
- <xmqqfqy0xrm7.fsf@gitster.g>
- In-Reply-To
- <atd8mopIi44pMBAC@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 14 quoted lines
> On Tue, Oct 20, 2026 at 02:37:05PM +0200, Harald Nordgren wrote: >> > I'm a bit on the fence about whether we want to have a regression test >> > or not. It feels like a very specific thing in the user-facing output, >> > so it's a bit dubious whether it's really worth it. But on the other >> > hand, folks like you seem to care enough to make the test worthwhile, so >> > maybe we should have one? >> >> It seems self-evident that we need a regression test here. Because >> it's specifically the thing that would have prevented it, and the only >> thing that will prevent a new regression later on :) > > I wouldn't necessarily say self-evident as the result isn't wrong. It's > still correct, even though it has changed compared to the previous > status quo.
It is correct in the sense that it is not wrong, but we cannot deny that it is much less useful when trying to determine where the new repository was created while reading a transcript that contains an invocation of the 'git init' command. One would need to go back and see where the user in the transcript 'cd'ed to before issuing the command.
This episode makes me wonder what other details, not captured in our existing tests, users find useful and have grown accustomed to.
Thanks.