git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] init: show absolute path of (re)initialized repository

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 26, 2026, 07:01 UTC
Message-ID
<at76u_L1yiot329r@pks.im>
In-Reply-To
<DMC7P4CPEV2X.25XRRSBEZCFPH@lfurio.us>
On Fri, Oct 23, 2026 at 08:21:11AM -0400, Matt Hunter wrote:
Show 25 quoted lines
> On Fri Oct 23, 2026 at 2:26 AM EDT, Patrick Steinhardt wrote:
> > On Thu, Oct 22, 2026 at 08:06:32AM -0400, Matt Hunter wrote:
> >>  
> >> +test_expect_success 'init shows absolute path to gitdir' '
> >> +	expect="$(pwd)/init-path" &&
> >
> > I don't think this extra variable buys us anything, so I'd just drop it.
> >
> >> +	git init init-path >actual &&
> >> +	test_grep "$expect" actual
> >> +'
> >
> > I would have tested for the whole message, which is short enough to be
> > reasonable, I'd say.
> 
> I considered this.  I decided on this simpler version since there are
> 4 possible messages that could appear at the end of git init.  Do we
> want separate tests/assertions to check all outputs
> 
>     "Reinitialized existing shared Git repository in %s%s"
>     "Reinitialized existing Git repository in %s%s"
>     "Initialized empty shared Git repository in %s%s"
>     "Initialized empty Git repository in %s%s"
> 
> are as expected?
I feel like that'd probably be a bit excessive.
Show 12 quoted lines
> Furthermore, the final path element is configurable as well, though
> should just be ".git" in the case of these tests.  I figured, since the
> actual breakage was about the appearance of the path, then I would just
> test _that aspect_ of the output in this test.
> 
> How do we feel about this assertion
> 
>     echo "Initialized empty Git repository in $(pwd)/init-path/.git/" >expect
>     test_cmp expect actual
> 
> which tests the whole message of just the default case?  The unnecessary
> variable you point out above is repurposed into a needed tmp file.
I'd say that's good enough for now. Thanks!
Patrick
Previous: Matt HunterNext: Matt Hunter
Message 12 of 15 in “init: show absolute path of (re)initialized repository”
  1. init: show absolute path of (re)initialized repositoryMatt Hunter, Oct 20, 2026
  2. Patrick SteinhardtOct 20, 2026
  3. Matt HunterOct 20, 2026
  4. Patrick SteinhardtOct 20, 2026
  5. Harald NordgrenOct 20, 2026
  6. Patrick SteinhardtOct 20, 2026
  7. Harald NordgrenOct 20, 2026
  8. Junio C HamanoOct 20, 2026
  9. init: show absolute path of (re)initialized repositoryMatt Hunter, Oct 22, 2026
  10. Patrick SteinhardtOct 23, 2026
  11. Matt HunterOct 23, 2026
  12. Patrick SteinhardtOct 26, 2026
  13. init: show absolute path of (re)initialized repositoryMatt Hunter, Oct 28, 2026
  14. Patrick SteinhardtOct 28, 2026
  15. Junio C HamanoOct 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.