From: Patrick Steinhardt Date: Fri, 23 Oct 2026 06:26:46 GMT Subject: Re: [PATCH v2] init: show absolute path of (re)initialized repository Message-ID: In-Reply-To: <20261022120749.3567828-1-m@lfurio.us> On Thu, Oct 22, 2026 at 08:06:32AM -0400, Matt Hunter wrote: > diff --git a/t/t0001-init.sh b/t/t0001-init.sh > index f1d227f27167..fbf8a0e41dad 100755 > --- a/t/t0001-init.sh > +++ b/t/t0001-init.sh > @@ -1000,4 +1000,10 @@ test_expect_success 'init honors GIT_OBJECT_DIRECTORY' ' > test_path_is_dir custom-odb/info > ' > > +test_expect_success 'init shows absolute path to gitdir' ' > + expect="$(pwd)/init-path" && I don't think this extra variable buys us anything, so I'd just drop it. > + git init init-path >actual && > + test_grep "$expect" actual > +' I would have tested for the whole message, which is short enough to be reasonable, I'd say. Other than those nits I'm happy, thanks! Patrick