git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/3] imap-send: use the recommended TLS_method()

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 19, 2026, 06:39 UTC
Message-ID
<atW7CLcWmKRk4sMv@pks.im>
In-Reply-To
<20261017100956.529225-1-dev+git@drbeat.li>
On Sat, Oct 17, 2026 at 12:09:54PM +0200, Beat Bolli wrote:
Show 9 quoted lines
> SSLv23_method() has been deprecated since OpenSSL 1.1.0, and
> TLS_method() is the recommended function[1].
> 
> Let's use the current function, lest a reader of the code thinks we
> don't support current TLS versions.
> 
> [1]: https://docs.openssl.org/master/man3/SSL_CTX_new/#history
> 
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
I would have appreciated a cover letter that points out:
  - What this series is doing.
  - What has changed between v2 and v3, ideally including a range-diff.

Like, why is there a third patch now, for example? I have no idea, so for reviews to go smooth and efficient we require help from the authors of a given patch series.

I would recommend using b4 going forward, which automatically manages all of those details for you.

Also, we strongly encourage folks to please reply to review feedback directly instead of just sending the next version of a patch series.

Patrick
Previous: Patrick SteinhardtNext: Beat Bolli
Message 19 of 23 in “imap-send: future proofing and two correctness fixes”
  1. 0/3 imap-send: future proofing and two correctness fixesBeat Bolli, Sep 7, 2026
  2. 3/3 imap-send: only check the CN if no SAN DNS names are presentBeat Bolli, Sep 7, 2026
  3. brian m. carlsonSep 8, 2026
  4. 2/3 imap-send: don't expect an ASN1_STRING to be NUL-terminatedBeat Bolli, Sep 7, 2026
  5. Junio C HamanoSep 8, 2026
  6. Patrick SteinhardtSep 8, 2026
  7. 1/3 imap-send: prepare for OpenSSL 4.1Beat Bolli, Sep 7, 2026
  8. Junio C HamanoSep 8, 2026
  9. Patrick SteinhardtSep 8, 2026
  10. Beat BolliSep 14, 2026
  11. Patrick SteinhardtSep 23, 2026
  12. 1/2 imap-send: use the recommended TLS_method()Beat Bolli, Oct 12, 2026
  13. 1/3 imap-send: use the recommended TLS_method()Beat Bolli, Oct 17, 2026
  14. 2/3 imap-send: let OpenSSL do the hostname verificationBeat Bolli, Oct 17, 2026
  15. Patrick SteinhardtOct 19, 2026
  16. Xiangfei DingOct 19, 2026
  17. 3/3 imap-send: prepare for OpenSSL 4.0Beat Bolli, Oct 17, 2026
  18. Patrick SteinhardtOct 19, 2026
  19. Patrick SteinhardtOct 19, 2026
  20. 2/2 imap-send: let OpenSSL do the hostname verificationBeat Bolli, Oct 12, 2026
  21. Aniket GuptaOct 12, 2026
  22. Xiangfei DingOct 16, 2026
  23. Patrick SteinhardtOct 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.