From: Taylor Blau <ttaylorr@openai.com>
Date: Thu, 01 Oct 2026 03:14:59 GMT
Subject: Re: [PATCH 2/4] pack-objects: ensure tree/tag closure with '--stdin-packs=follow'
Message-ID: <ar3QM2QkmXfq11xc@com-79390>
In-Reply-To: <a78a38ca-b08a-4194-b17c-b8802e4d43a7@gmail.com>

On Wed, Sep 30, 2026 at 02:16:53PM -0400, Derrick Stolee wrote:
> > @@ -3807,6 +3807,7 @@ static int stdin_packs_hints_nr;
> >  struct stdin_packs_context {
> >  	struct rev_info *revs;
> >  	enum stdin_packs_mode mode;
> > +	struct oid_array extra_roots;
>
> I believe this should be an oidset to avoid adding duplicate objects
> that appear multiple times. The order of these extra roots doesn't
> matter (such as in a --topo-order walk). We only care about the
> binary "reachable or not?" question.

Great suggestion! I adjusted it in the following round.

Thanks,
Taylor