Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

From

Tony Finch <dot@dotat.at>

Date

Jul 4, 2013, 15:56 UTC

Message-ID

<alpine.LSU.2.00.1307041646250.26246@hermes-2.csi.cam.ac.uk>

In-Reply-To

<CANQwDwfCYPBjGfmKOLju-Zey4WrVrXfaymJtu9g1OYvOUfBTcw@mail.gmail.com>

Jakub Narębski <jnareb@gmail.com> wrote:

>
> First, do I understand corrctly that @extra_breadcrumbs are rendered *after*
> $home_link*, and in exactly the same manner?

> But now I think that we can do better, simply put $home_link_str and $home_link
> in @extra_breadcrumbs / @top_level_breadcrumbs / @nav_breadcrumbs before
> using it,

We could save a line that way:

-       print $cgi->a({-href => esc_url($home_link)}, $home_link_str) . " / ";
+       for my $crumb (@extra_breadcrumbs, [ $home_link_str => $home_link ]) {
+               print $cgi->a({-href => esc_url($crumb->[1])}, $crumb->[0]) . " / ";
+       }

> P.S. It is a bit late, but wouldn't { name => $link_name, href => $link_url }
> (like %features hash) be a better solution than [ $link_name, $link_url ],
> i.e. hashref (named parameters) instead of arrayref (positional parameters).
> You wouldn't have to remember which is first: text or URL.

I thought the fat arrow would be mnemonic enough, and less verbose.

Tony.

-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
occasionally poor at first.