Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

From: Tony Finch <dot@dotat.at>
Date: Jul 4, 2013, 15:11 UTC
Message-ID: <alpine.LSU.2.00.1307041559140.26246@hermes-2.csi.cam.ac.uk>
In-Reply-To: <CANQwDwd9siyeu5xqS5Un+=8ioEaDbpT30vBpgJCVNUEcszcv1g@mail.gmail.com>

Jakub Narębski <jnareb@gmail.com> wrote:

>
> It would be better to improve documentation, than follow current bad
> practice... ;-P

The v2 patch does just that :-)

> Perhaps even make ( [ $home_link_str, $home_link ] ) to be default
> value for @extra_breadcrumbs, making new feature generalization
> of $home_link*, similarly to how it was done for $stylesheet -> @stylesheets
> transition.

I don't think that's a win. There's a lot of existing gitweb.conf out there which sets $home_link_str, so the code would have to either print the last element of @extra_breadcrumbs or the $home_link variables depending on whether the variables were modified. And the documentation would have to explain this complicated arrangement.

Tony.

-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
occasionally poor at first.