Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail
- From
Jakub Narębski <jnareb@gmail.com>
- Date
- Jul 3, 2013, 22:11 UTC
- Message-ID
- <CANQwDwcneUzzXS-Du-3Aca3-Vp8ycSzVqUv1rVRVhaNUWfeokw@mail.gmail.com>
- In-Reply-To
- <20130703215930.GT408@google.com>
On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Tony Finch wrote:
Show 16 quoted lines
>> +@extra_breadcrumbs:: >> + Additional links to be added to the start of the breadcrumb trail, >> + that are logically "above" the gitweb projects list. For example, >> + links to the organization and department which host the gitweb >> + server. Each element of the list is a reference to an array, >> + in which element 0 is the link text and element 1 is the >> + target URL. > > Is arbitrary HTML permitted in the link text? > > I think it makes sense to permit it for consistency with $home_link_str, > but it might be worth mentioning in the manpage so the administrator > knows not to set it to something user-controlled --- e.g.: > > The link text can contain arbitrary HTML --- to escape link > text generated programatically, use esc_html($text).
Nb. it would be nice to have relation of @extra_breadcrumbs with $home_link_str explained.
-- Jakub Narebski