Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

From

Tony Finch <dot@dotat.at>

Date

Jul 4, 2013, 08:44 UTC

Message-ID

<alpine.LSU.2.00.1307040940400.26246@hermes-2.csi.cam.ac.uk>

In-Reply-To

<CANQwDwcneUzzXS-Du-3Aca3-Vp8ycSzVqUv1rVRVhaNUWfeokw@mail.gmail.com>

Jakub Narębski <jnareb@gmail.com> wrote:

> On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> > Tony Finch wrote:
>
> >> +@extra_breadcrumbs::
> >> +     Additional links to be added to the start of the breadcrumb trail,
> >> +     that are logically "above" the gitweb projects list. For example,
> >> +     links to the organization and department which host the gitweb
> >> +     server. Each element of the list is a reference to an array,
> >> +     in which element 0 is the link text and element 1 is the
> >> +     target URL.
> >
> > Is arbitrary HTML permitted in the link text?

> > I think it makes sense to permit it for consistency with $home_link_str,
> > but it might be worth mentioning in the manpage so the administrator
> > knows not to set it to something user-controlled --- e.g.:

> Nb. it would be nice to have relation of @extra_breadcrumbs with
> $home_link_str explained.

I will make that clearer.

Thanks for reviewing the patch.

Tony.

-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
occasionally poor at first.