Re: [PATCH] send-email: confirm on empty mail subjects

From: Jan Engelhardt <jengelh@medozas.de>
Date: Aug 25, 2009, 16:27 UTC
Message-ID: <alpine.LSU.2.00.0908251825150.21065@fbirervta.pbzchgretzou.qr>
In-Reply-To: <7v1vn1gjlp.fsf@alter.siamese.dyndns.org>

On Montag 2009-08-24 20:19, Junio C Hamano wrote:

Show 14 quoted lines

>>>
>>>> When the user forgot to enter a subject in a compose session,
>>>> send-email will now inquire whether this is really intended, similar
>>>> to what the Alpine MUA does when a subject is absent.
>>>
>>>This seems to break t9001...
>>
>> Did I miss something in building?
>>
>> 19:26 sovereign:../git/git-1.6.4.1 > quilt pu
>> Applying patch patches/send-email-empty-subject.diff
>> patching file git-send-email.perl
>
>Is this using 'pu' with your patch?

Ah no, `quilt pu` is an autoalias for `quilt push`.

>Near the tip of the 'pu' branch I
>have a iffy workaround to "unbreak" the issue, but it is a rather
>sledgehammer approach I do not feel comfortable enough to squash into your
>patch yet.

I see. Perhaps

	echo -en 'y\ny\n' | ...

would be more gentle? (Noting that, how else should it be, many a shell do not have -e/-n again.)