Re: [PATCH] send-email: confirm on empty mail subjects
- From
- Jan Engelhardt <jengelh@medozas.de>
- Date
- Aug 24, 2009, 17:27 UTC
- Message-ID
- <alpine.LSU.2.00.0908241927300.5382@fbirervta.pbzchgretzou.qr>
- In-Reply-To
- <7vhbwlpigo.fsf@alter.siamese.dyndns.org>
On Thursday 2009-08-06 08:25, Junio C Hamano wrote:
Show 8 quoted lines
>Jan Engelhardt <jengelh@medozas.de> writes: > >> When the user forgot to enter a subject in a compose session, >> send-email will now inquire whether this is really intended, similar >> to what the Alpine MUA does when a subject is absent. > >This seems to break t9001... >
Did I miss something in building?
19:26 sovereign:../git/git-1.6.4.1 > quilt pu Applying patch patches/send-email-empty-subject.diff patching file git-send-email.perl
Now at patch patches/send-email-empty-subject.diff 19:26 sovereign:../git/git-1.6.4.1 > cd t 19:26 sovereign:../git-1.6.4.1/t > ./t9001-send-email.sh * ok 1: prepare reference tree * ok 2: Setup helper tool * ok 3: Extract patches * ok 4: No confirm with --suppress-cc * ok 5: No confirm with --confirm=never * ok 6: No confirm with sendemail.confirm=never * ok 7: Send patches * ok 8: Verify commandline * ok 9: Show all headers * ok 10: Prompting works * ok 11: cccmd works * ok 12: reject long lines * ok 13: no patch was sent * ok 14: Author From: in message body * ok 15: Author From: not in message body * ok 16: allow long lines with --no-validate * ok 17: Invalid In-Reply-To * ok 18: Valid In-Reply-To when prompting * ok 19: setup fake editor * ok 20: --compose works * ok 21: first message is compose text * ok 22: second message is patch * ok 23: sendemail.cc set * ok 24: sendemail.cc unset * ok 25: sendemail.cccmd * ok 26: --suppress-cc=all * ok 27: --suppress-cc=body * ok 28: --suppress-cc=body --suppress-cc=cccmd * ok 29: --suppress-cc=sob * ok 30: --suppress-cc=bodycc * ok 31: --suppress-cc=cc * ok 32: --confirm=always * ok 33: --confirm=auto * ok 34: --confirm=cc * ok 35: --confirm=compose * ok 36: confirm by default (due to cc) * ok 37: confirm by default (due to --compose) * ok 38: confirm detects EOF (inform assumes y) * ok 39: confirm detects EOF (auto causes failure) * ok 40: confirm doesnt loop forever * ok 41: utf8 Cc is rfc2047 encoded * ok 42: --compose adds MIME for utf8 body * ok 43: --compose respects user mime type * ok 44: --compose adds MIME for utf8 subject * ok 45: detects ambiguous reference/file conflict * ok 46: feed two files * ok 47: in-reply-to but no threading * ok 48: no in-reply-to and no threading * ok 49: threading but no chain-reply-to * passed all 49 test(s)