[PATCH] send-email: confirm on empty mail subjects
- From
- Jan Engelhardt <jengelh@medozas.de>
- Date
- Aug 5, 2009, 16:49 UTC
- Message-ID
- <1249490994-23455-1-git-send-email-jengelh@medozas.de>
When the user forgot to enter a subject in a compose session, send-email will now inquire whether this is really intended, similar to what the Alpine MUA does when a subject is absent.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de> --- git-send-email.perl | 25 ++++++++++++++++++++----- 1 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index d508f83..7d56fba 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -553,11 +553,26 @@ EOT } close(C); - if ($annotate) { - do_edit($compose_filename, @files); - } else { - do_edit($compose_filename); - } + my $re_edit = 0; + do { + if ($annotate) { + do_edit($compose_filename, @files); + } else { + do_edit($compose_filename); + } + + open(C, "<", $compose_filename) || + die "Failed to open $compose_filename: $!"; + if (grep(/^Subject:\s*$/i, <C>)) { + my $r = ask("No Subject, send anyway? ". + "([y]es|[n]o|[e]dit again): ", + valid_re => qr/^[yne]/i, + default => "n"); + $re_edit = lc(substr($r, 0, 1)) eq "e"; + exit(0) if lc(substr($r, 0, 1)) eq "n"; + } + close C; + } while ($re_edit); open(C2,">",$compose_filename . ".final") or die "Failed to open $compose_filename.final : " . $!;
-- 1.6.4