Re: [PATCH] send-email: confirm on empty mail subjects

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2009, 17:35 UTC
Message-ID: <7veiqzpzjn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.2.00.0908251825150.21065@fbirervta.pbzchgretzou.qr>

Jan Engelhardt <jengelh@medozas.de> writes:

Show 11 quoted lines

>>Near the tip of the 'pu' branch I
>>have a iffy workaround to "unbreak" the issue, but it is a rather
>>sledgehammer approach I do not feel comfortable enough to squash into your
>>patch yet.
>
> I see. Perhaps
>
> 	echo -en 'y\ny\n' | ...
>
> would be more gentle? (Noting that, how else should it be,
> many a shell do not have -e/-n again.)

You can solve it with printf "y\ny\n", but the reason I said it feels wrong was because your added tests are the _only_ ones that expect more than one "yes".

If some _other_ tests that currently need only one "yes" are broken in the future and starts asking for more than one, we would like to know about the breakage, but we won't notice it if we unconditionally fed "yes | ..." or your "two y's | ..." to them. That is what I am unhappy about the "iffy workaround".