git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] builtin-prune: protect objects listed on the command line

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 27, 2008, 16:35 UTC
Message-ID
<alpine.LSU.1.00.0803271735010.3802@racer.site>
In-Reply-To
<7vve389lgc.fsf@gitster.siamese.dyndns.org>
Hi,
On Thu, 27 Mar 2008, Junio C Hamano wrote:
Show 15 quoted lines
> Junio C Hamano <junio@pobox.com> writes:
> 
> > From: Junio C Hamano <gitster@pobox.com>
> > Date: Mon, 24 Mar 2008 23:20:51 -0700
> >
> > Finally, this resurrects the documented behaviour to protect other 
> > objects listed on the command line from getting pruned.
> >
> > Signed-off-by: Junio C Hamano <gitster@pobox.com> ---
> >  * This is done deliberately differently from what you did.  Because 
> >    we do not want to accept "we allow losing what's reachable from 
> >    master" with "git prune master..next", setup_revisions() is not the 
> >    right thing to use for this command.
> 
> Ping?

I did not see any problem with your implementation, but I thought Michele would look more deeply, as he obviously cares about the to-be-fixed behaviour.

Ciao, Dscho

Previous: Junio C HamanoNext: Michele Ballabio
Message 21 of 22 in “builtin-prune.c: fix object parsing and use parse_options()”
  1. 2/2 builtin-prune.c: fix object parsing and use parse_options()Michele Ballabio, Mar 23, 2008
  2. Johannes SchindelinMar 23, 2008
  3. Michele BallabioMar 24, 2008
  4. Johannes SchindelinMar 24, 2008
  5. 3/2 parse-options.c: introduce OPT_DATEMichele Ballabio, Mar 24, 2008
  6. Johannes SchindelinMar 24, 2008
  7. Michele BallabioMar 24, 2008
  8. Johannes SchindelinMar 24, 2008
  9. Junio C HamanoMar 24, 2008
  10. Michele BallabioMar 24, 2008
  11. Junio C HamanoMar 25, 2008
  12. 1/5 parse-options.c: introduce OPT_DATEJunio C Hamano, Mar 25, 2008
  13. 2/5 test_must_fail: 129 is a valid error code from usage()Junio C Hamano, Mar 25, 2008
  14. Johannes SchindelinMar 25, 2008
  15. Johannes SixtMar 25, 2008
  16. Johannes SchindelinMar 25, 2008
  17. 3/5 Add tests for git-pruneJunio C Hamano, Mar 25, 2008
  18. 4/5 builtin-prune.c: use parse_options()Junio C Hamano, Mar 25, 2008
  19. 5/5 builtin-prune: protect objects listed on the command lineJunio C Hamano, Mar 25, 2008
  20. Junio C HamanoMar 27, 2008
  21. Johannes SchindelinMar 27, 2008
  22. Michele BallabioMar 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.