git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] test_must_fail: 129 is a valid error code from usage()

From
Junio C Hamano <junio@pobox.com>
Date
Mar 25, 2008, 06:59 UTC
Message-ID
<7vbq53nvaz.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200803242218.44026.barra_cuda@katamail.com>
From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Mar 2008 23:07:08 -0700

When a git command is run under test_must_fail to make sure that the argument parser catches bogus command line, it exits with 129. We need to catch it as a valid "graceful error exit".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/test-lib.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 870b255..7c2a8ba 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -300,7 +300,7 @@ test_expect_code () {
 
 test_must_fail () {
 	"$@"
-	test $? -gt 0 -a $? -le 128
+	test $? -gt 0 -a $? -le 129
 }
 
 # test_cmp is a helper function to compare actual and expected output.
-- 
1.5.5.rc1.121.g1594
Previous: Junio C HamanoNext: Johannes Schindelin
Message 13 of 22 in “builtin-prune.c: fix object parsing and use parse_options()”
  1. 2/2 builtin-prune.c: fix object parsing and use parse_options()Michele Ballabio, Mar 23, 2008
  2. Johannes SchindelinMar 23, 2008
  3. Michele BallabioMar 24, 2008
  4. Johannes SchindelinMar 24, 2008
  5. 3/2 parse-options.c: introduce OPT_DATEMichele Ballabio, Mar 24, 2008
  6. Johannes SchindelinMar 24, 2008
  7. Michele BallabioMar 24, 2008
  8. Johannes SchindelinMar 24, 2008
  9. Junio C HamanoMar 24, 2008
  10. Michele BallabioMar 24, 2008
  11. Junio C HamanoMar 25, 2008
  12. 1/5 parse-options.c: introduce OPT_DATEJunio C Hamano, Mar 25, 2008
  13. 2/5 test_must_fail: 129 is a valid error code from usage()Junio C Hamano, Mar 25, 2008
  14. Johannes SchindelinMar 25, 2008
  15. Johannes SixtMar 25, 2008
  16. Johannes SchindelinMar 25, 2008
  17. 3/5 Add tests for git-pruneJunio C Hamano, Mar 25, 2008
  18. 4/5 builtin-prune.c: use parse_options()Junio C Hamano, Mar 25, 2008
  19. 5/5 builtin-prune: protect objects listed on the command lineJunio C Hamano, Mar 25, 2008
  20. Junio C HamanoMar 27, 2008
  21. Johannes SchindelinMar 27, 2008
  22. Michele BallabioMar 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.