From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 27 Mar 2008 16:35:46 GMT
Subject: Re: [PATCH 5/5] builtin-prune: protect objects listed on the command line
Message-ID: <alpine.LSU.1.00.0803271735010.3802@racer.site>
In-Reply-To: <7vve389lgc.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 27 Mar 2008, Junio C Hamano wrote:

> Junio C Hamano <junio@pobox.com> writes:
> 
> > From: Junio C Hamano <gitster@pobox.com>
> > Date: Mon, 24 Mar 2008 23:20:51 -0700
> >
> > Finally, this resurrects the documented behaviour to protect other 
> > objects listed on the command line from getting pruned.
> >
> > Signed-off-by: Junio C Hamano <gitster@pobox.com> ---
> >  * This is done deliberately differently from what you did.  Because 
> >    we do not want to accept "we allow losing what's reachable from 
> >    master" with "git prune master..next", setup_revisions() is not the 
> >    right thing to use for this command.
> 
> Ping?

I did not see any problem with your implementation, but I thought Michele 
would look more deeply, as he obviously cares about the to-be-fixed 
behaviour.

Ciao,
Dscho