Re: [PATCH 3/2] parse-options.c: introduce OPT_DATE
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 25, 2008, 06:58 UTC
- Message-ID
- <7vmyonnvbr.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <200803242218.44026.barra_cuda@katamail.com>
Michele Ballabio <barra_cuda@katamail.com> writes:
Show 11 quoted lines
> On Monday 24 March 2008, Junio C Hamano wrote:
>> Michele Ballabio <barra_cuda@katamail.com> writes:
>>
>> > +int parse_opt_approxidate_cb(const struct option *opt, const char *arg,
>> > + int unset)
>> > +{
>> > + *(unsigned int *)(opt->value) = approxidate(arg);
>>
>> Doesn't approxidate return ulong, not uint?
>
> Yes, you're right.Now, it is getting somewhat tiring to keep track of "oops, that was wrong, and here is a fix-up on top".
So here is my attempt to summarize by presenting them in an order that I think is sensible.