git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-submodule: Don't die when command fails for one submodule

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 4, 2008, 15:01 UTC
Message-ID
<alpine.LSU.1.00.0803041500170.22527@racer.site>
In-Reply-To
<1204641314-2726-1-git-send-email-pkufranky@gmail.com>
Hi,
On Tue, 4 Mar 2008, Ping Yin wrote:
> When handling multiple modules, init/update/status command will exit 
> when it fails for one submodule. This patch makes the command continue 
> bypassing the failure.

I think that you should not do this. The failure should not be ignored. Maybe continuing, but not forgetting about the error. So:

> -		name=$(module_name "$path") || exit
> +		name=$(module_name "$path") || continue

I do not like this. It should remember that there was something foul, and eventually exit with that status.

Ciao, Dscho

Previous: Ping YinNext: Ping Yin
Message 2 of 7 in “git-submodule: Don't die when command fails for one submodule”
  1. git-submodule: Don't die when command fails for one submodulePing Yin, Mar 4, 2008
  2. Johannes SchindelinMar 4, 2008
  3. Ping YinMar 4, 2008
  4. Johannes SchindelinMar 4, 2008
  5. Ping YinMar 4, 2008
  6. Johannes SchindelinMar 4, 2008
  7. Junio C HamanoMar 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.