Re: [PATCH] git-submodule: Don't die when command fails for one submodule

From: Ping Yin <pkufranky@gmail.com>
Date: Mar 4, 2008, 16:00 UTC
Message-ID: <46dff0320803040800o499bb77bsa033134bda43becb@mail.gmail.com>
In-Reply-To: <alpine.LSU.1.00.0803041500170.22527@racer.site>

On Tue, Mar 4, 2008 at 11:01 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 19 quoted lines

> Hi,
>
>
>  On Tue, 4 Mar 2008, Ping Yin wrote:
>
>  > When handling multiple modules, init/update/status command will exit
>  > when it fails for one submodule. This patch makes the command continue
>  > bypassing the failure.
>
>  I think that you should not do this.  The failure should not be ignored.
>  Maybe continuing, but not forgetting about the error.  So:
>
>
>  > -             name=$(module_name "$path") || exit
>  > +             name=$(module_name "$path") || continue
>
>  I do not like this.  It should remember that there was something foul, and
>  eventually exit with that status.
>

The error output is not lost and is in module_name

>  Ciao,
>  Dscho
>
>

-- 
Ping Yin