Re: [PATCH] git-submodule: Don't die when command fails for one submodule

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 4, 2008, 20:32 UTC
Message-ID: <7vzlte44dg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <46dff0320803040806y5ed02b86p9216ddc752f3052@mail.gmail.com>

"Ping Yin" <pkufranky@gmail.com> writes:

Show 15 quoted lines

> On Wed, Mar 5, 2008 at 12:03 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> Hi,
>>
>>
>>  On Wed, 5 Mar 2008, Ping Yin wrote:
>>
>>  > The error output is not lost and is in module_name
>>
>>  That's what I am saying: the error output is not enough.  The exit status
>>  needs to indicate that there was an error, too.  Everything else is
>>  unusable by scripts.
>
> I think this can be done in a following patch which capture any error
> and give the right exit status.

Please.

"You are absolutely right. I'll fix it in my next round to do frotz and xyzzy as you suggested. I want to make my next round better with fixes and improvements based on other comments I will receive during this round, so it will be at least in a few days. Thanks."

That's how I want to see things work around here.